Differential D19702

Page changes triggered by mouse clicks should all happen on button release
ClosedPublic
Actions

Authored by sander on Mar 12 2019, 10:08 AM.

Details

Reviewers
ngraham
aacid
Group Reviewers
Okular
Commits
R223:4094745e7ea6: Page changes triggered by mouse clicks should all happen on button release
Summary

Previously this was inconsistent: left button clicks triggered page changes at release, but right button and forward/backward button clicks triggered directly at the mousePressEvent.

Diff Detail

Repository
R223 Okular
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
sander created this revision.Mar 12 2019, 10:08 AM
Restricted Application added a project: Okular. · View Herald TranscriptMar 12 2019, 10:08 AM
Restricted Application added a subscriber: okular-devel. · View Herald Transcript
sander requested review of this revision.Mar 12 2019, 10:08 AM
ngraham accepted this revision.Mar 12 2019, 1:44 PM
This revision is now accepted and ready to land.Mar 12 2019, 1:44 PM
aacid requested changes to this revision.Mar 12 2019, 9:39 PM
aacid added a subscriber: aacid.
aacid added inline comments.
ui/presentationwidget.cpp
746

This comment need updating then?

This revision now requires changes to proceed.Mar 12 2019, 9:39 PM
sander updated this revision to Diff 53954.Mar 15 2019, 1:53 PM

Updated the comment

sander marked an inline comment as done.Mar 15 2019, 1:53 PM
sander added a comment.Mar 26 2019, 5:45 AM

Is this okay now?

aacid accepted this revision.Mar 26 2019, 8:46 PM

The comment still neds updating, but i'll fix it myself when i land it

This revision is now accepted and ready to land.Mar 26 2019, 8:46 PM
Closed by commit R223:4094745e7ea6: Page changes triggered by mouse clicks should all happen on button release (authored by sander, committed by aacid). · Explain WhyMar 26 2019, 9:21 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mui/presentationwidget.cpp (8 lines)

Diff 54894

View Options

ui/presentationwidget.cpp

Loading...