Make it possible to extract random text from a document
ClosedPublic
Actions

Authored by apol on Jun 21 2016, 5:38 PM.

Details

Reviewers

Group Reviewers

Commits

Summary

Forwards the call to the KTextEditor interface, when there's such an interface.

Repository

R33 KDevPlatform

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

apol retitled this revision from to Make it possible to extract random text from a document.

apol updated this object.

apol edited the test plan for this revision. (Show Details)

apol added a reviewer: KDevelop.

mwolff added inline comments.

shell/textdocument.cpp
488	why do we need a view to get the text in a range? makes no sense to me. can't you just remove this?

Remove unused conditional

lgtm

This revision is now accepted and ready to land.Jun 22 2016, 12:14 PM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			interfaces/idocument.h (5 lines)
M			interfaces/idocument.cpp (6 lines)
M			shell/textdocument.h (2 lines)
M			shell/textdocument.cpp (9 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	4664	2a98b47		Jun 21 2016, 5:38 PM	★	★
Diff 2	4670	2a98b47	Remove unused conditional	Jun 22 2016, 10:37 AM	★	★
Diff 3	4674	2a98b47	rKDEVPLATFORM5bb514155ffadec288361287fc4b8d0810e00688	Jun 22 2016, 3:16 PM	★	★