Differential D19674

[Icon Item] Also clear image icon when using Plasma Svg
ClosedPublic
Actions

Authored by broulik on Mar 11 2019, 8:48 AM.

Details

Reviewers
apol
Group Reviewers
Plasma
Commits
R242:017954185c83: [Icon Item] Also clear image icon when using Plasma Svg
Summary

When changing an IconItem from using a local image (e.g. PNG file) to using a Plasma themed icon, the implicit size wasn't updated since the old image was still loaded in m_imageIcon. Clearing it when clearing the other icon stores fixes this.

BUG: 405298

Test Plan
  • Changed kickoff icon to be a rectangular image, reset it back to default, button size updated correctly

Diff Detail

Repository
R242 Plasma Framework (Library)
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Mar 11 2019, 8:48 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptMar 11 2019, 8:48 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
broulik requested review of this revision.Mar 11 2019, 8:48 AM
apol accepted this revision.Mar 11 2019, 12:06 PM
This revision is now accepted and ready to land.Mar 11 2019, 12:06 PM
Closed by commit R242:017954185c83: [Icon Item] Also clear image icon when using Plasma Svg (authored by broulik). · Explain WhyMar 11 2019, 12:28 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 53646

View Options

src/declarativeimports/core/iconitem.cpp

Loading...