Fix fc-solve misbehaving preset.
ClosedPublic

Authored by shlomif on Mar 11 2019, 1:08 AM.

Details

Summary

See https://bugs.kde.org/show_bug.cgi?id=405187 . Apparently
incrementally increasing the iterations limit does not play nice with
the freecell-solver's "flare"s feature.

slick-rock does not use flares but may yield somewhat longer solutions
than video-editing.

Diff Detail

Repository
R410 KPatience
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
shlomif created this revision.Mar 11 2019, 1:08 AM
Restricted Application added a reviewer: KDE Games. · View Herald TranscriptMar 11 2019, 1:08 AM
Restricted Application added a subscriber: kde-games-devel. · View Herald Transcript
shlomif requested review of this revision.Mar 11 2019, 1:08 AM
aacid added a subscriber: aacid.Mar 11 2019, 11:31 PM

is this something unit/auto testable?

shlomif updated this revision to Diff 53706.Mar 12 2019, 7:58 AM
  • Add an assert and a test for bz405187
aacid accepted this revision.Mar 14 2019, 9:25 PM

I'm not going to pretend i understand what this is about, but it now has an autotest (even though it looks a bit weird starting the binary).

i don't think anyone knows more to review this, so if you're confident it works, go ahead i'd say.

This revision is now accepted and ready to land.Mar 14 2019, 9:25 PM
This revision was automatically updated to reflect the committed changes.