Differential D19662

Fix Qmake based build
ClosedPublic
Actions

Authored by ognarb on Mar 10 2019, 10:12 PM.

Details

Reviewers
mart
Group Reviewers
Kirigami
Commits
R169:f7100e2c9ca6: Fix Qmake based build
Summary

This patch should resolve https://www.reddit.com/r/kde/comments/azgfbj/cant_compile_kirigami_for_android/

Also fix a warning duplicate entry in qrc

Test Plan

Build with cmake and qmake works

Diff Detail

Repository
R169 Kirigami
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 9454
Build 9472: arc lint + arc unit
ognarb created this revision.Mar 10 2019, 10:12 PM
Restricted Application added a project: Kirigami. · View Herald TranscriptMar 10 2019, 10:12 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ognarb requested review of this revision.Mar 10 2019, 10:12 PM
mart requested changes to this revision.Mar 11 2019, 3:11 PM
mart added a subscriber: mart.
mart added inline comments.
kirigami.qrc
21

this file still exists

This revision now requires changes to proceed.Mar 11 2019, 3:11 PM
mart accepted this revision.Mar 11 2019, 3:13 PM
This revision is now accepted and ready to land.Mar 11 2019, 3:13 PM
Closed by commit R169:f7100e2c9ca6: Fix Qmake based build (authored by ognarb). · Explain WhyMar 11 2019, 3:15 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mkirigami.qrc (3 lines)

Diff 53621

View Options

kirigami.qrc

Loading...