adding multiple decays and updated isotope information H-Na
ClosedPublic

Authored by joergbuchwald on Mar 6 2019, 10:57 AM.

Details

Reviewers
tcanabrava
aacid
Group Reviewers
Kalzium
Summary

-Adding combined decay types like alphabetaminusdecay....
-updated isotope information H-Ne with the information from https://en.wikipedia.org/wiki/Category:Isotopes
-work will be continued/completed in next weeks

Diff Detail

Repository
R326 Kalzium
Lint
Lint Skipped
Unit
Unit Tests Skipped
joergbuchwald created this revision.Mar 6 2019, 10:57 AM
Restricted Application added a project: KDE Edu. · View Herald TranscriptMar 6 2019, 10:57 AM
Restricted Application added a subscriber: kde-edu. · View Herald Transcript
joergbuchwald requested review of this revision.Mar 6 2019, 10:57 AM
tcanabrava accepted this revision.Apr 9 2019, 8:39 AM
This revision is now accepted and ready to land.Apr 9 2019, 8:39 AM
aacid added a subscriber: aacid.Apr 10 2019, 9:43 PM

@tcanabrava will you commit this to master or want me to?

aacid added a comment.Apr 15 2019, 9:23 PM

@joergbuchwald you mentioned "work will be continued/completed in next weeks", is this still true or should this be commited?

aacid requested changes to this revision.Jul 21 2019, 8:54 AM

Requesting changes until someone answers my questions

This revision now requires changes to proceed.Jul 21 2019, 8:54 AM
This comment was removed by joergbuchwald.

Hi,
I updated now the entire table of isotopes, based on the
german/english wikipedia.
(Of course, still not complete...)
I also added most of the possible decay types (including multiple
particle decay).
I had some troubles in uploading the new patch using phabricator.
Therefore, here again Bzipped by email.

Jörg

Am Sun, 21 Jul 2019 08:54:47 +0000
schrieb Albert Astals Cid <noreply@phabricator.kde.org>:

aacid requested changes to this revision.
aacid added a comment.
This revision now requires changes to proceed.

Requesting changes until someone answers my questions

REPOSITORY

R326 Kalzium

REVISION DETAIL

https://phabricator.kde.org/D19563

To: joergbuchwald, Kalzium, tcanabrava, aacid
Cc: aacid, kde-edu, narvaez, apol

Looks legitimate.

+1

I still found some issues in isotopes.xml related to data consitency as these data is as merge of multiple sources.
I'll try to fix them, besides removing the commented out old code in detailinfodlg.cpp. There are also some contradictions between the data of the german and the english wikipedia.
However, it is still a great effort to ensure the correctness of the data and also quite hard to handle it on my own, but the current version of kalzium is quite incomplete in that sense, especially with the
respect to decay types, and multiple decays, that I would say this patch is still a real progress.

aacid accepted this revision.Oct 13 2019, 9:27 PM
This revision is now accepted and ready to land.Oct 13 2019, 9:27 PM
aacid closed this revision.Oct 13 2019, 9:28 PM

I've pushed this to git.

Please continue your work in a new phabricator request :)