Differential D19549

Fix build with julia 1.1
ClosedPublic
Actions

Authored by arojas on Mar 5 2019, 6:43 PM.

Details

Reviewers
sirgienko
Commits
R55:00d5e5375df1: Fix build with julia 1.1
R55:499b9d90337e: Fix build with julia 1.1
Summary

Adapt to API changes in julia 1.1

Test Plan

Builds with julia 1.0.3 and 1.1, seems to work.

Diff Detail

Repository
R55 Cantor
Lint
Lint Skipped
Unit
Unit Tests Skipped
arojas created this revision.Mar 5 2019, 6:43 PM
Restricted Application added a project: KDE Edu. · View Herald TranscriptMar 5 2019, 6:43 PM
Restricted Application added a subscriber: kde-edu. · View Herald Transcript
arojas requested review of this revision.Mar 5 2019, 6:43 PM
sirgienko accepted this revision.Mar 5 2019, 8:05 PM

Good job, thanks.

A question, @arojas, how you found this problem, on build step? I have read 1.1 release news, but as I see, julia team hasen't mention, that C-API for exception changed.

This revision is now accepted and ready to land.Mar 5 2019, 8:05 PM
sirgienko requested changes to this revision.Mar 5 2019, 8:27 PM

According tests, error prints not work properly, for example sqrt(-1) produces error during run:
nothing

This revision now requires changes to proceed.Mar 5 2019, 8:27 PM
arojas updated this revision to Diff 53242.Mar 5 2019, 9:28 PM

Fix exception display

arojas added a comment.Mar 5 2019, 9:29 PM
In D19549#425406, @sirgienko wrote:

A question, @arojas, how you found this problem, on build step? I have read 1.1 release news, but as I see, julia team hasen't mention, that C-API for exception changed.

Yes, I found out when building 18.12.3. I also couldn't find anything in the release notes, I had to dig into the git log to figure out the changes

sirgienko accepted this revision.Mar 5 2019, 9:41 PM

Yes, now a exception display works fine.

This revision is now accepted and ready to land.Mar 5 2019, 9:41 PM
Closed by commit R55:00d5e5375df1: Fix build with julia 1.1 (authored by arojas). · Explain WhyMar 5 2019, 9:46 PM
This revision was automatically updated to reflect the committed changes.
sirgienko added a comment.Mar 5 2019, 9:54 PM

@arojas, The fix lands to master branch, is it should be? I have thought, the fix needed on Applications/18.12 branch.

arojas added a subscriber: cfeck.Mar 5 2019, 9:57 PM

The last 18.12 release tarballs are done already, so unless you think this is worth a respin there's no point to merge it. (cc @cfeck )

cfeck added a comment.Mar 5 2019, 10:32 PM

I will do a respin if I see a commit in Applications/18.12 branch within the next 12 hours.

Revision Contents
Changeset List

Diff 53242

View Options

src/backends/julia/juliaserver/juliaserver.cpp

Loading...