Differential D19465

Port to ECM's component/imported target based FindXCB
ClosedPublic
Actions

Authored by vkrause on Mar 2 2019, 11:01 AM.

Details

Reviewers
apol
Commits
R119:8c28ac839ad5: Port to ECM's component/imported target based FindXCB

Diff Detail

Repository
R119 Plasma Desktop
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 9058
Build 9076: arc lint + arc unit
vkrause created this revision.Mar 2 2019, 11:01 AM
Restricted Application added a project: Plasma. · View Herald TranscriptMar 2 2019, 11:01 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
vkrause requested review of this revision.Mar 2 2019, 11:01 AM
apol accepted this revision.Mar 4 2019, 1:56 AM
This revision is now accepted and ready to land.Mar 4 2019, 1:56 AM
Closed by commit R119:8c28ac839ad5: Port to ECM's component/imported target based FindXCB (authored by vkrause). · Explain WhyMar 4 2019, 7:14 PM
This revision was automatically updated to reflect the committed changes.
rikmills added a subscriber: rikmills.EditedMar 9 2019, 9:20 AM

Results in cmake configure build failure on Neon

https://build.neon.kde.org/job/bionic_unstable_kde_plasma-desktop_bin_amd64/292/consoleFull

EDIT: My bad. Change now requires libxcb-util-dev is installed as a build dep. Not very clear from the error.

Revision Contents
Changeset List

Diff 52948

View Options

kcms/touchpad/cmake/modules/COPYING-CMAKE-SCRIPTS

Loading...
View Options

kcms/touchpad/cmake/modules/FindXCB.cmake

Loading...
View Options

kcms/touchpad/src/backends/x11.cmake

Loading...