[Icon Item] Block next animation also based on window visibility
ClosedPublic

Authored by broulik on Feb 28 2019, 2:31 PM.

Details

Summary

Plasma Dialog used to change the item's visiblity but this is no longer the case, so it would animate when a window is shown and the source has changed in the meantime.

Test Plan

Changed volume, waited for OSD to disappear, changed brightness, OSD would no longer show while animating from the old pixmap.
Changed volume, and changed brightness right away, OSD would still animate

WIP because the first animation for each icon item isn't animated as the item is usually assigned a window which then becomes visible as such blocking the animation :/ Turns out this bug isn't caused or related to this at all \o/ In Desktop Containment the applet container is invisible initially so it always goes through a hide-and-show cycle

Diff Detail

Repository
R242 Plasma Framework (Library)
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Feb 28 2019, 2:31 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptFeb 28 2019, 2:31 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
broulik requested review of this revision.Feb 28 2019, 2:31 PM
mart accepted this revision.Feb 28 2019, 2:52 PM
This revision is now accepted and ready to land.Feb 28 2019, 2:52 PM
broulik retitled this revision from WIP: [Icon Item] Block next animation also based on window visibility to [Icon Item] Block next animation also based on window visibility.Feb 28 2019, 2:52 PM
broulik edited the test plan for this revision. (Show Details)
This revision was automatically updated to reflect the committed changes.