Differential D1941

Fix compiling with Qt < 5.4
ClosedPublic
Actions

Authored by kossebau on Jun 18 2016, 12:07 AM.

Details

Reviewers
nienhueser
rahn
Commits
R34:09b30cc4e5bf: Fix compiling with Qt < 5.4
Summary

QVector::removeAll/QVector::removeOne were only added in Qt 5.4.
So use custom implementation with older Qt versions (like on SailfishOS, where currently still only Qt 5.2 is used, work on going 5.6 only started).

Test Plan

Builds on SailfishOS and my tumbleweed laptop.

Diff Detail

Repository
R34 Marble
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
kossebau updated this revision to Diff 4600.Jun 18 2016, 12:07 AM
kossebau retitled this revision from to Fix compiling with Qt < 5.4.
kossebau updated this object.
kossebau edited the test plan for this revision. (Show Details)
kossebau added reviewers: nienhueser, rahn.
kossebau set the repository for this revision to R34 Marble.
kossebau added a project: Marble.
nienhueser accepted this revision.Jun 19 2016, 7:31 PM
nienhueser edited edge metadata.

Looks good.

This revision is now accepted and ready to land.Jun 19 2016, 7:31 PM
Closed by commit R34:09b30cc4e5bf: Fix compiling with Qt < 5.4 (authored by kossebau). · Explain WhyJun 21 2016, 2:29 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 4662

View Options

src/lib/marble/geodata/data/GeoDataContainer.cpp

Loading...