Differential D19396

[kxmlgui] remove deprecated method
ClosedPublic
Actions

Authored by mlaurent on Feb 27 2019, 7:23 PM.

Details

Reviewers
dfaure
Commits
R263:8069268ceda6: [kxmlgui] remove deprecated method
Summary

remove deprecated method

Diff Detail

Repository
R263 KXmlGui
Branch
remove_deprecated_method (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 8965
Build 8983: arc lint + arc unit
mlaurent created this revision.Feb 27 2019, 7:23 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptFeb 27 2019, 7:23 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
mlaurent requested review of this revision.Feb 27 2019, 7:23 PM
dfaure requested changes to this revision.Feb 27 2019, 10:24 PM

Same comment as in https://phabricator.kde.org/D19395, the rest looks good.

This revision now requires changes to proceed.Feb 27 2019, 10:24 PM
mlaurent updated this revision to Diff 52794.Feb 28 2019, 7:57 AM

Disable deprecated method until qt5.12

dfaure accepted this revision.Feb 28 2019, 10:08 AM
This revision is now accepted and ready to land.Feb 28 2019, 10:08 AM
Closed by commit R263:8069268ceda6: [kxmlgui] remove deprecated method (authored by mlaurent). · Explain WhyFeb 28 2019, 12:09 PM
This revision was automatically updated to reflect the committed changes.

Showing Only Differences

This revision modifies 4 more files that are hidden because they were not modified between selected diffs and they have no inline comments.

Revision Contents
Changeset List

PathPackages
MCMakeLists.txt (2 lines)

Diff 52794

View Options

CMakeLists.txt

Loading...