[KJobWidget] remove deprecated method
ClosedPublic

Authored by mlaurent on Feb 27 2019, 7:23 PM.

Details

Summary

remove deprecated method

Diff Detail

Repository
R288 KJobWidgets
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mlaurent created this revision.Feb 27 2019, 7:23 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptFeb 27 2019, 7:23 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
mlaurent requested review of this revision.Feb 27 2019, 7:23 PM
dfaure requested changes to this revision.Feb 27 2019, 10:23 PM
dfaure added inline comments.
CMakeLists.txt
47

Since it's commented out, it's not really useful to add it.

And yeah we can't add it yet, since new things might become deprecated with 6.0.

Maybe you could add it with 0x050C00 (5.12) at least [assuming this is the right value, please check], and we can then upgrade all of that with a script once 6.0 is out? (after checking that everything compiles)

This revision now requires changes to proceed.Feb 27 2019, 10:23 PM
mlaurent updated this revision to Diff 52793.Feb 28 2019, 7:55 AM

Disable deprecated method until 5.12 as requested

mlaurent marked an inline comment as done.Feb 28 2019, 7:55 AM
dfaure accepted this revision.Feb 28 2019, 10:08 AM
This revision is now accepted and ready to land.Feb 28 2019, 10:08 AM
This revision was automatically updated to reflect the committed changes.