Differential D19396

[kxmlgui] remove deprecated method
ClosedPublic
Actions

Authored by mlaurent on Feb 27 2019, 7:23 PM.

Tags

Subscribers

kde-frameworks-devel

Details

Reviewers

Commits

R263:8069268ceda6: [kxmlgui] remove deprecated method

Summary

remove deprecated method

Diff Detail

Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

mlaurent created this revision.Feb 27 2019, 7:23 PM

Restricted Application added a project: Frameworks. · View Herald TranscriptFeb 27 2019, 7:23 PM

Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript

mlaurent requested review of this revision.Feb 27 2019, 7:23 PM

Harbormaster completed remote builds in B8949: Diff 52767.Feb 27 2019, 7:23 PM

Same comment as in https://phabricator.kde.org/D19395, the rest looks good.

This revision now requires changes to proceed.Feb 27 2019, 10:24 PM

Disable deprecated method until qt5.12

Harbormaster completed remote builds in B8965: Diff 52794.Feb 28 2019, 7:57 AM

dfaure accepted this revision.Feb 28 2019, 10:08 AM

This revision is now accepted and ready to land.Feb 28 2019, 10:08 AM

Closed by commit R263:8069268ceda6: [kxmlgui] remove deprecated method (authored by mlaurent). · Explain WhyFeb 28 2019, 12:09 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			CMakeLists.txt (2 lines)
M			autotests/kmainwindow_unittest.cpp (2 lines)
M			autotests/ktoolbar_unittest.cpp (2 lines)
M			autotests/kxmlgui_unittest.cpp (2 lines)
M			src/ktoolbar.cpp (2 lines)

Diff 52802

CMakeLists.txt

Loading...

autotests/kmainwindow_unittest.cpp

Loading...

autotests/ktoolbar_unittest.cpp

Loading...

autotests/kxmlgui_unittest.cpp

Loading...

src/ktoolbar.cpp

Loading...