Differential D19329

allow GeoDataCoordinates::toString() to create an ISO 6709 conforming string
Needs ReviewPublic
Actions

Authored by mkoller on Feb 26 2019, 10:15 AM.

Details

Reviewers
rahn
nienhueser
Group Reviewers
Marble: General
Summary

ISO 6709 "Standard representation of geographic point location by coordinates"
ISO6709
says that coordinate order is latitude before longitude, however the existing toString() method does it lon-lat.

This patch introduces a flag optionally allowing to create an ISO conforming return value.

Diff Detail

Repository
R34 Marble
Lint
Lint Skipped
Unit
Unit Tests Skipped
mkoller created this revision.Feb 26 2019, 10:15 AM
Restricted Application added projects: Marble, KDE Edu. · View Herald TranscriptFeb 26 2019, 10:15 AM
Restricted Application added subscribers: kde-edu, marble-devel. · View Herald Transcript
mkoller requested review of this revision.Feb 26 2019, 10:15 AM
rahn added a comment.Feb 26 2019, 10:50 AM

apart from the Boolean issue this looks good to me and can be submitted.

lib/marble/geodata/data/GeoDataCoordinates.h
392

such booleans as parameters always look dull (https://ariya.io/2011/08/hall-of-api-shame-boolean-trap). What about using an enum instead ?

mkoller updated this revision to Diff 52603.Feb 26 2019, 12:47 PM

Changed bool to enum

Revision Contents
Changeset List

Diff 52603

View Options

lib/marble/geodata/data/GeoDataCoordinates.h

Loading...
View Options

lib/marble/geodata/data/GeoDataCoordinates.cpp

Loading...