Differential D19319

make it compile without foreach
ClosedPublic
Actions

Authored by mlaurent on Feb 25 2019, 8:50 PM.

Details

Reviewers
dfaure
Commits
R291:4ac2a1c5eeba: make it compile without foreach
Summary

compile without foreach

Diff Detail

Repository
R291 KPty
Branch
compile_without_foreach (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 8923
Build 8941: arc lint + arc unit
mlaurent created this revision.Feb 25 2019, 8:50 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptFeb 25 2019, 8:50 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
mlaurent requested review of this revision.Feb 25 2019, 8:50 PM
apol added a subscriber: apol.Feb 26 2019, 2:53 PM

Looks odd, it's not necessary any changes?

src/kpty.cpp
88 ↗(On Diff #52561)

Unrelated? Commit separately.

mlaurent updated this revision to Diff 52699.Feb 27 2019, 5:50 AM

Remove not necessary change

dfaure accepted this revision.Mar 2 2019, 11:02 PM
This revision is now accepted and ready to land.Mar 2 2019, 11:02 PM
Closed by commit R291:4ac2a1c5eeba: make it compile without foreach (authored by mlaurent). · Explain WhyMar 3 2019, 8:33 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
MCMakeLists.txt (1 line)
Msrc/kpty.cpp (2 lines)

Diff 52699

View Options

CMakeLists.txt

Loading...
View Options

src/kpty.cpp

Loading...