Differential D19318

compile without foreach
ClosedPublic
Actions

Authored by mlaurent on Feb 25 2019, 8:46 PM.

Details

Reviewers
dfaure
Commits
R274:b072248cc681: compile without foreach
Summary

compile without foreach

Diff Detail

Repository
R274 KIdleTime
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mlaurent created this revision.Feb 25 2019, 8:46 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptFeb 25 2019, 8:46 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
mlaurent requested review of this revision.Feb 25 2019, 8:46 PM
dfaure accepted this revision.Mar 2 2019, 10:54 PM
dfaure added inline comments.
src/kidletime.cpp
253

Urgh, how horrible and slow. But pre-existing, unrelated to your change.

This revision is now accepted and ready to land.Mar 2 2019, 10:54 PM
Closed by commit R274:b072248cc681: compile without foreach (authored by mlaurent). · Explain WhyMar 3 2019, 8:33 AM
This revision was automatically updated to reflect the committed changes.
hindenburg added a subscriber: hindenburg.Mar 23 2019, 4:57 PM

There's a FOREACH still in the macpoller.cpp file

Revision Contents
Changeset List

PathPackages
MCMakeLists.txt (2 lines)
Msrc/kidletime.cpp (13 lines)
Msrc/widgetbasedpoller.cpp (4 lines)

Diff 53042

View Options

CMakeLists.txt

Loading...
View Options

src/kidletime.cpp

Loading...
View Options

src/widgetbasedpoller.cpp

Loading...