Differential D19317

compile without foreach
ClosedPublic
Actions

Authored by mlaurent on Feb 25 2019, 8:45 PM.

Details

Reviewers
dfaure
apol
Commits
R287:f1c6c15b061b: compile without foreach
Summary

compile without foreach

Diff Detail

Repository
R287 KImageFormats
Branch
compile_without_foreach (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 8924
Build 8942: arc lint + arc unit
mlaurent created this revision.Feb 25 2019, 8:45 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptFeb 25 2019, 8:45 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
mlaurent requested review of this revision.Feb 25 2019, 8:45 PM
apol added a subscriber: apol.Feb 26 2019, 2:51 PM
apol added inline comments.
src/imageformats/pic.cpp
391 ↗(On Diff #52559)

Probably could do a splitRef here

tests/imageconverter.cpp
67 ↗(On Diff #52559)

I'd use auto in this cases, otherwise you're creating a dependency to the type.

mlaurent updated this revision to Diff 52700.Feb 27 2019, 5:58 AM

Use auto as requested

mlaurent added inline comments.Feb 27 2019, 5:58 AM
src/imageformats/pic.cpp
391 ↗(On Diff #52559)

it seems that we can't use it.
As it will return a list of QStringRef
and we want to use "simplified() on a QStringRef which doesn't exist

apol accepted this revision.Feb 28 2019, 4:25 PM
apol added inline comments.
tests/imagedump.cpp
75

auto too?

This revision is now accepted and ready to land.Feb 28 2019, 4:25 PM
Closed by commit R287:f1c6c15b061b: compile without foreach (authored by mlaurent). · Explain WhyFeb 28 2019, 10:02 PM
This revision was automatically updated to reflect the committed changes.

Showing Only Differences

This revision modifies 3 more files that are hidden because they were not modified between selected diffs and they have no inline comments.

Revision Contents
Changeset List

PathPackages
Msrc/imageformats/pic.cpp (12 lines)
Mtests/imageconverter.cpp (6 lines)
Mtests/imagedump.cpp (3 lines)

Diff 52700

View Options

src/imageformats/pic.cpp

Loading...
View Options

tests/imageconverter.cpp

Loading...
View Options

tests/imagedump.cpp

Loading...