Use ActionTextField to implement the searchField in system settings
ClosedPublic

Authored by ognarb on Feb 25 2019, 6:49 PM.

Details

Summary

Needs Kirigami latest version (master) and D19314

Warning: Remove the opacity change animation. :(

Diff Detail

Repository
R124 System Settings
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ognarb created this revision.Feb 25 2019, 6:49 PM
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 25 2019, 6:49 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ognarb requested review of this revision.Feb 25 2019, 6:49 PM
ognarb edited the summary of this revision. (Show Details)
ognarb planned changes to this revision.Feb 25 2019, 6:52 PM
ognarb retitled this revision from Use ActionTextField to implement the searchField to WIP: Use ActionTextField to implement the searchField.
ognarb edited the summary of this revision. (Show Details)
ognarb removed a reviewer: Plasma.
ognarb edited the summary of this revision. (Show Details)Feb 25 2019, 8:27 PM
ognarb requested review of this revision.Feb 26 2019, 11:43 AM
ognarb retitled this revision from WIP: Use ActionTextField to implement the searchField to Use ActionTextField to implement the searchField.
ognarb edited the summary of this revision. (Show Details)
ognarb added a reviewer: Plasma.
ognarb edited the summary of this revision. (Show Details)Feb 26 2019, 11:48 AM
ognarb retitled this revision from Use ActionTextField to implement the searchField to Use ActionTextField to implement the searchField in system settings.Feb 26 2019, 11:53 AM
ngraham accepted this revision.Mar 3 2019, 9:49 PM
ngraham added a subscriber: ngraham.

Nice!

If you're upset about losing the animation, we could add that to the action buttons of the ActionTextField component itself.

This revision is now accepted and ready to land.Mar 3 2019, 9:49 PM
This revision was automatically updated to reflect the committed changes.