Differential D19273

Button to open downloads file directory
AbandonedPublic
Actions

Authored by cullmann on Feb 24 2019, 12:52 PM.

Details

Reviewers
krishremya
Group Reviewers
Falkon
Summary

[Feature request] Button to open downloads directory in 'download complete' notification.

Bug ID: Bug 394746

Diff Detail

Repository
R875 Falkon
Lint
Lint Skipped
Unit
Unit Tests Skipped
krishremya created this revision.Feb 24 2019, 12:52 PM
Restricted Application added a subscriber: falkon. · View Herald TranscriptFeb 24 2019, 12:52 PM
krishremya requested review of this revision.Feb 24 2019, 12:52 PM
ognarb added a subscriber: ognarb.Feb 24 2019, 2:24 PM
ognarb added inline comments.
src/lib/downloads/downloadmanager.cpp
414

Not a Falkon developer, but this URL should depend on of $USER and not your Linux username. :)

Also, there is a 'Location for Personal Files' KCM in the system settings that define a Downloads path.

cullmann requested changes to this revision.Feb 24 2019, 4:43 PM
This revision now requires changes to proceed.Feb 24 2019, 4:43 PM
drosca added a subscriber: drosca.Feb 25 2019, 8:11 AM

This is wrong, there two ways to add button to notification that opens file/directory:

  1. Implement KJob tracking for downloads and it will automatically show Open button, but it will only work with platforms that support it (probably only Plasma)
  2. Use actions parameter in \org.freedesktop.Notifications.Notify` call (https://people.gnome.org/~mccann/docs/notification-spec/notification-spec-latest.html)
cullmann commandeered this revision.Jun 24 2019, 7:00 PM
cullmann edited reviewers, added: krishremya; removed: cullmann.

> Please submit a new version if you have time, thanks!

cullmann abandoned this revision.Jun 24 2019, 7:00 PM

Revision Contents
Changeset List

Diff 52439

View Options

src/lib/downloads/downloadmanager.h

Loading...
View Options

src/lib/downloads/downloadmanager.cpp

Loading...