[KWin] Skip fall apart effect on virtual desktop change
Needs ReviewPublic

Authored by matthieugras on Feb 23 2019, 10:24 PM.

Details

Reviewers
None
Group Reviewers
KWin
Summary

BUG: 404747

Test Plan

Enable fall apart effect in the settings, close a window and quickly change the virtual desktop -> no crash

Diff Detail

Repository
R108 KWin
Branch
arcpatch-D19265
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 8790
Build 8808: arc lint + arc unit
matthieugras created this revision.Feb 23 2019, 10:24 PM
Restricted Application added a project: KWin. · View Herald TranscriptFeb 23 2019, 10:24 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
matthieugras requested review of this revision.Feb 23 2019, 10:24 PM

remove extra new line

remove "win"

For the bug you're trying to work round, we want to do disable not when the desktop changes, but when an active full screen effect gets activated.

It's not a proper fix, but it's also not a bad solution.
If we do this, we should do it in magic lamp too.

Handle fullscreen effect changed instead of desktop change and update the magic lamp effect

small correction

zzag added a subscriber: zzag.Feb 24 2019, 6:41 PM
zzag added inline comments.
effects/magiclamp/magiclamp.cpp
138

unrealated change

undo unrelated change

ngraham edited the summary of this revision. (Show Details)Feb 24 2019, 8:18 PM
zzag added inline comments.Feb 24 2019, 8:20 PM
effects/fallapart/fallapart.cpp
60

Why isn't windows cleared same way as m_animations in the magic lamp effect?

ngraham added a subscriber: ngraham.

@matthieugras Ping! :)