Differential D19224

Only report DocBookXML as found if it was actually found
ClosedPublic
Actions

Authored by apol on Feb 22 2019, 12:47 PM.

Details

Reviewers
ltoscano
Group Reviewers
Frameworks
Commits
R238:acf8d5352402: Only report DocBookXML as found if it was actually found
Summary

Otherwise we generate files with paths such as "searched_dir-NOTFOUND/docbookx.dtd"

Diff Detail

Repository
R238 KDocTools
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 8690
Build 8708: arc lint + arc unit
apol created this revision.Feb 22 2019, 12:47 PM
Restricted Application added projects: Frameworks, Documentation. · View Herald TranscriptFeb 22 2019, 12:47 PM
Restricted Application added subscribers: kde-doc-english, kde-frameworks-devel. · View Herald Transcript
apol requested review of this revision.Feb 22 2019, 12:47 PM
apol updated this revision to Diff 52296.Feb 22 2019, 1:11 PM

Include a warning about how it wasn't found

ltoscano requested changes to this revision.Feb 22 2019, 1:15 PM
This revision now requires changes to proceed.Feb 22 2019, 1:15 PM
apol added a comment.Feb 22 2019, 1:31 PM

@ltoscano you said that you want changes to happen but didn't mention what needs changing?

ltoscano added a comment.Feb 22 2019, 1:38 PM

Sorry, I forgot to save a comment.

cmake/FindDocBookXML4.cmake
88

Isn't ${found_dir} undefined at this point?

apol marked an inline comment as done.Feb 22 2019, 1:56 PM
apol added inline comments.
cmake/FindDocBookXML4.cmake
88

no, this is an argument to the function and it has to contain the output variable, as used in the line 86.

ltoscano accepted this revision.Feb 22 2019, 1:59 PM

Right, sorry.

This revision is now accepted and ready to land.Feb 22 2019, 1:59 PM
Closed by commit R238:acf8d5352402: Only report DocBookXML as found if it was actually found (authored by apol). · Explain WhyFeb 22 2019, 3:14 PM
This revision was automatically updated to reflect the committed changes.
apol marked an inline comment as done.

Revision Contents
Changeset List

PathPackages
Mcmake/FindDocBookXML4.cmake (6 lines)

Diff 52296

View Options

cmake/FindDocBookXML4.cmake

Loading...