Remove Qt5WebKitWidgets dependency and build gui unconditionally.
ClosedPublic

Authored by palimaka on Jun 16 2016, 7:45 PM.

Details

Summary

Qt5WebKitWidgets is not actually used anywhere.

Diff Detail

Repository
R106 KSysguard
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
palimaka updated this revision to Diff 4558.Jun 16 2016, 7:45 PM
palimaka retitled this revision from to Remove Qt5WebKitWidgets dependency and build gui unconditionally..
palimaka updated this object.
palimaka added reviewers: Plasma, sgaist.

You sure?

libksysguard/processui uses it

processui/CMakeLists.txt: target_link_libraries(processui PRIVATE Qt5::WebKitWidgets)

and gui links against processui

libksysguard/processui uses Qt5WebKitWidgets optionally and privately only for the detailed memory function.

The ksysguard gui itself builds and runs fine regardless of libksysguard's build options.

libksysguard/processui uses Qt5WebKitWidgets optionally and privately only for the detailed memory function.

The ksysguard gui itself builds and runs fine regardless of libksysguard's build options.

and how is runtime then? Does it work or cause a problem. If it works just fine, I'd say we ship it and see what build.kde.org says to it.

The GUI works fine at runtime. The only difference is in the detailed memory information dialogue in libksysguard, which if compiled without Qt5WebKitWidgets displays an error dialogue (see RR 125887).

I confirmed this by building ksysguard with this patch, then running it against both libksysguard variants - it worked correctly for me in each case.

davidedmundson accepted this revision.Jun 23 2016, 12:10 PM
davidedmundson added a reviewer: davidedmundson.
This revision is now accepted and ready to land.Jun 23 2016, 12:10 PM
graesslin accepted this revision.Jun 23 2016, 12:41 PM
graesslin added a reviewer: graesslin.
This revision was automatically updated to reflect the committed changes.