Qt5WebKitWidgets is not actually used anywhere.
Details
- Reviewers
davidedmundson sgaist graesslin - Group Reviewers
Plasma - Commits
- R106:c4e448a116c4: Remove Qt5WebKitWidgets dependency and build gui unconditionally.
Diff Detail
- Repository
- R106 KSysguard
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
You sure?
libksysguard/processui uses it
processui/CMakeLists.txt: target_link_libraries(processui PRIVATE Qt5::WebKitWidgets)
and gui links against processui
libksysguard/processui uses Qt5WebKitWidgets optionally and privately only for the detailed memory function.
The ksysguard gui itself builds and runs fine regardless of libksysguard's build options.
and how is runtime then? Does it work or cause a problem. If it works just fine, I'd say we ship it and see what build.kde.org says to it.
The GUI works fine at runtime. The only difference is in the detailed memory information dialogue in libksysguard, which if compiled without Qt5WebKitWidgets displays an error dialogue (see RR 125887).
I confirmed this by building ksysguard with this patch, then running it against both libksysguard variants - it worked correctly for me in each case.