Prepare for LLDB DebugSession: Let MIDebugSession handle MICommand instantiation
ClosedPublic

Authored by qi437103 on Jun 16 2016, 7:04 PM.

Details

Summary

Let MIDebugSession handle most MICommand instantiations, so that lldb DebugSession has a chance to use custom command type. Also fixed a bug in MIDebugger that stdout is read instead of stderr when stderr is ready to read.

Following this would be another RR that actually add a basic LLDBDebugSession.

Test Plan

use unit tests under gdb folder

Diff Detail

Repository
R32 KDevelop
Lint
No Linters Available
Unit
No Unit Test Coverage
qi437103 updated this revision to Diff 4557.Jun 16 2016, 7:04 PM
qi437103 retitled this revision from to Prepare for LLDB DebugSession: Let MIDebugSession handle MICommand instantiation.
qi437103 updated this object.
qi437103 edited the test plan for this revision. (Show Details)
qi437103 added a reviewer: apol.
Restricted Application added a subscriber: kdevelop-devel. · View Herald TranscriptJun 16 2016, 7:04 PM
apol accepted this revision.Jun 20 2016, 3:00 PM
apol edited edge metadata.

I like it, the API looks cleaner as well.

I assume tests still pass. Go for it, merge to master.

debuggers/common/mibreakpointcontroller.cpp
407

QStringLiteral

This revision is now accepted and ready to land.Jun 20 2016, 3:00 PM
apol added a comment.Jun 20 2016, 3:01 PM

On future reviews, add KDevelop as Subscriber, so other devels can comment on it.

qi437103 added a comment.EditedJun 20 2016, 3:07 PM

Yes tests pass.

I thought arcanist will automatically add KDevelop. Will do that next time :)

This revision was automatically updated to reflect the committed changes.