Differential D1918

Prepare for LLDB DebugSession: Let MIDebugSession handle MICommand instantiation
ClosedPublic
Actions

Authored by qi437103 on Jun 16 2016, 7:04 PM.

Details

Reviewers

Commits

R32:2e68ddbb72e8: Prepare for LLDB DebugSession: Let MIDebugSession handle MICommand instantiation

Summary

Let MIDebugSession handle most MICommand instantiations, so that lldb DebugSession has a chance to use custom command type. Also fixed a bug in MIDebugger that stdout is read instead of stderr when stderr is ready to read.

Following this would be another RR that actually add a basic LLDBDebugSession.

Test Plan

use unit tests under gdb folder

Diff Detail

Repository

R32 KDevelop

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

qi437103 updated this revision to Diff 4557.Jun 16 2016, 7:04 PM

qi437103 retitled this revision from to Prepare for LLDB DebugSession: Let MIDebugSession handle MICommand instantiation.

qi437103 updated this object.

qi437103 edited the test plan for this revision. (Show Details)

qi437103 added a reviewer: apol.

Restricted Application added a subscriber: kdevelop-devel. · View Herald TranscriptJun 16 2016, 7:04 PM

I like it, the API looks cleaner as well.

I assume tests still pass. Go for it, merge to master.

debuggers/common/mibreakpointcontroller.cpp
407	QStringLiteral

This revision is now accepted and ready to land.Jun 20 2016, 3:00 PM

On future reviews, add KDevelop as Subscriber, so other devels can comment on it.

Yes tests pass.

I thought arcanist will automatically add KDevelop. Will do that next time :)

Closed by commit R32:2e68ddbb72e8: Prepare for LLDB DebugSession: Let MIDebugSession handle MICommand instantiation (authored by qi437103). · Explain WhyJun 20 2016, 3:09 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			debuggers/common/mi/micommand.h (64 lines)
M			debuggers/common/mi/micommand.cpp (39 lines)
M			debuggers/common/mibreakpointcontroller.h (3 lines)
M			debuggers/common/mibreakpointcontroller.cpp (63 lines)
M			debuggers/common/midebugger.cpp (2 lines)
M			debuggers/common/midebugsession.h (38 lines)
M			debuggers/common/midebugsession.cpp (109 lines)
M			debuggers/common/miframestackmodel.cpp (8 lines)
M			debuggers/common/mivariable.cpp (37 lines)
M			debuggers/common/mivariablecontroller.cpp (33 lines)
M			debuggers/gdb/debugsession.cpp (60 lines)
M			debuggers/gdb/disassemblewidget.cpp (8 lines)
M			debuggers/gdb/registers/registercontroller.cpp (7 lines)
M			debuggers/gdb/registers/registersmanager.cpp (3 lines)
M			debuggers/gdb/unittests/test_gdb.cpp (6 lines)