only enable the module help button if the module actually has help

Authored by sitter on Feb 20 2019, 3:26 PM.



the module help button specifically launches the help for DocPath set in
the desktop file of the KCM, previously the code however only checked if
the KCM pragmatically disabled the help button. while supposedly its good
form for a module to explicitly disable the help button when it has no help
but since that depends on humans to remember doing that it's a bit

so, the module help button now only gets enabled when there actually is
module help available AND the button wasn't explicitly disabled.
this prevents the help button from getting enabled but then launching
the generic khelpcenter since no actual DocPath was set in the kcm
desktop metadata

Test Plan
  • about (has no doc and disables button) -> disabled button
  • memory (has doc) -> enabled button
  • energy (has no doc but doesn't explicitly disable button) -> disabled button

Diff Detail

R102 KInfoCenter
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
sitter created this revision.Feb 20 2019, 3:26 PM
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 20 2019, 3:26 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
sitter requested review of this revision.Feb 20 2019, 3:27 PM
apol accepted this revision.Feb 21 2019, 7:47 PM
This revision is now accepted and ready to land.Feb 21 2019, 7:47 PM
This revision was automatically updated to reflect the committed changes.