Differential D19181

[about-distro] run logo lookup via osrelease
ClosedPublic
Actions

Authored by sitter on Feb 20 2019, 1:50 PM.

Details

Reviewers
apol
Commits
R102:d5b56b448c90: [about-distro] run logo lookup via osrelease
Summary

new preference:

  • kcm-about-distrorc
  • os-release
  • hardcoded start-here-kde

this removes the need to duplicate the logo information in the kcm rc if
a distro already has it encoded in the os-release's LOGO value

CHANGELOG: About System can now use os-release's LOGO configuration

Test Plan

logo can be set from os-release

Diff Detail

Repository
R102 KInfoCenter
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
sitter created this revision.Feb 20 2019, 1:50 PM
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 20 2019, 1:50 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
sitter requested review of this revision.Feb 20 2019, 1:50 PM
apol added a subscriber: apol.Feb 21 2019, 7:50 PM
apol added inline comments.
Modules/about-distro/src/Module.cpp
153

Put os.logo as the fallback?

sitter updated this revision to Diff 52277.Feb 22 2019, 10:39 AM

use os.logo as fallback

sitter marked an inline comment as done.Feb 22 2019, 10:39 AM
sitter added inline comments.
Modules/about-distro/src/Module.cpp
153

hm, yeah, I do wonder why I wrote it the way I did.

sitter marked 2 inline comments as done.Feb 22 2019, 10:39 AM
apol accepted this revision.Feb 22 2019, 1:30 PM
This revision is now accepted and ready to land.Feb 22 2019, 1:30 PM
Closed by commit R102:d5b56b448c90: [about-distro] run logo lookup via osrelease (authored by sitter). · Explain WhyFeb 22 2019, 1:38 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 52298

View Options

Modules/about-distro/src/Module.cpp

Loading...