[Task Manager ToolTipDelegate] Match DesktopEntry for associating window/launcher with player
ClosedPublic

Authored by broulik on Jun 16 2016, 2:35 PM.

Details

Summary

The current approach of matching the MPRIS DBus interface suffix was a bit short-sighted. This patch makes it use the DesktopEntry provided by the application which should make it work with most players.

I don't know what implications connecting to all sources has but given task manager only creates one ToolTipDelegate at a time and you usually only have one player running anyway, shouldn't be too bad.

Test Plan

I can now control players I could not control previously

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik updated this revision to Diff 4553.Jun 16 2016, 2:35 PM
broulik retitled this revision from to [Task Manager ToolTipDelegate] Match DesktopEntry for associating window/launcher with player.
broulik updated this object.
broulik edited the test plan for this revision. (Show Details)
broulik added reviewers: Plasma, hein.
broulik set the repository for this revision to R119 Plasma Desktop.
Restricted Application added a project: Plasma. · View Herald TranscriptJun 16 2016, 2:35 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik added inline comments.Jun 16 2016, 3:01 PM
applets/taskmanager/package/contents/ui/ToolTipDelegate.qml
82 ↗(On Diff #4553)

that should probably be data[source] :)

hein accepted this revision.Jun 16 2016, 5:05 PM
hein edited edge metadata.
This revision is now accepted and ready to land.Jun 16 2016, 5:05 PM
sitter edited edge metadata.Jun 17 2016, 8:31 AM

This should fix https://bugs.kde.org/show_bug.cgi?id=361965 if I am not mistaken.

This revision was automatically updated to reflect the committed changes.