Differential D1911

[Smart Launcher Backend] Use KSharedConfig::openConfig
ClosedPublic
Actions

Authored by broulik on Jun 16 2016, 9:54 AM.

Details

Reviewers
hein
Group Reviewers
Plasma
Commits
R119:73b079c0a730: [Smart Launcher Backend] Use KSharedConfig::openConfig

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik updated this revision to Diff 4545.Jun 16 2016, 9:54 AM
broulik retitled this revision from to [Smart Launcher Backend] Use KSharedConfig::openConfig.
broulik updated this object.
broulik edited the test plan for this revision. (Show Details)
broulik added reviewers: Plasma, hein.
broulik set the repository for this revision to R119 Plasma Desktop.
Restricted Application added a project: Plasma. · View Herald TranscriptJun 16 2016, 9:54 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
hein accepted this revision.Jun 16 2016, 1:24 PM
hein edited edge metadata.
This revision is now accepted and ready to land.Jun 16 2016, 1:24 PM
davidedmundson added a subscriber: davidedmundson.Jun 16 2016, 3:32 PM

what does this achieve?

SharedConfig ref counts; you unless there's someone else holding a reference, it'll still be reloading it every time.

hein added a comment.Jun 16 2016, 5:03 PM

The Task Manager backend opens the same file.

Closed by commit R119:73b079c0a730: [Smart Launcher Backend] Use KSharedConfig::openConfig (authored by broulik). · Explain WhyJun 27 2016, 2:15 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 4772

View Options

applets/taskmanager/plugin/smartlaunchers/smartlauncherbackend.cpp

Loading...