Differential D19081

Use correct KStandardGuiItem "no" icon
ClosedPublic
Actions

Authored by GB_2 on Feb 16 2019, 1:48 PM.

Details

Reviewers
ngraham
Group Reviewers
Plasma
VDG
Commits
R236:d5cdd29f9630: Use correct KStandardGuiItem "no" icon
Summary

Changes the "no" icon to the correct one that is used in other places too.
Before:

After:

Test Plan

Open the Font Management KCM and click on the font deletion button.

Diff Detail

Repository
R236 KWidgetsAddons
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
GB_2 created this revision.Feb 16 2019, 1:48 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptFeb 16 2019, 1:48 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
GB_2 requested review of this revision.Feb 16 2019, 1:48 PM
GB_2 edited the test plan for this revision. (Show Details)Feb 16 2019, 1:49 PM
ngraham accepted this revision.Feb 16 2019, 2:39 PM
ngraham added a subscriber: ngraham.

+1.

Of course, Yes/No dialogs themselves should be avoided wherever possible in favor of buttons with more descriptive labels (e.g. "Do the Thing / Cancel").

https://hig.kde.org/components/assistance/message.html#appearance

This revision is now accepted and ready to land.Feb 16 2019, 2:39 PM
Closed by commit R236:d5cdd29f9630: Use correct KStandardGuiItem "no" icon (authored by GB_2). · Explain WhyFeb 16 2019, 3:43 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/kstandardguiitem.cpp (2 lines)

Diff 51871

View Options

src/kstandardguiitem.cpp

Loading...