All plugins are enabled by default.
Signed-off-by: Tomaz Canabrava <tomaz.canabrava@gmail.com>
Details
Details
Diff Detail
Diff Detail
- Repository
- R34 Marble
- Branch
- make_plugins_optional
- Lint
No Linters Available - Unit
No Unit Test Coverage
| CMakeLists.txt | ||
|---|---|---|
| 51 | This is a set of more than 30 plugins that satisfy a rather broad set of use cases. Is one option to toggle them all on/off enough? I don't see a great way to structure this further, so maybe we should keep it like this and can later on introduce another automated way to toggle building individual plugins. | |
| 52 | This one also contains around 30 plugins. Maybe options WITH_REVERSE_GEOCODING_PLUGINS, WITH_ROUTING_PLUGINS, WITH_PARSING_PLUGINS would be more useful which would affect the subsets indicated by the comments in src/plugins/runner/CMakeLists.txt? | |
| src/plugins/CMakeLists.txt | ||
| 2 | This option is already there in the existing cmake files. | |
Comment Actions
@tcanabrava Hi. What are the use-cases which motivated this patch, so we know what we are designing the solution here for?
As you have not followed-up on the current feedback, are you still interested in this patch, or can this review request be dropped?