Format EXIF photo flash data
ClosedPublic

Authored by astippich on Feb 12 2019, 9:03 PM.

Details

Summary

Translate the number of the EXIF
photo data to a human readable
string.

CCBUG: 343273

Diff Detail

Repository
R286 KFileMetaData
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
astippich created this revision.Feb 12 2019, 9:03 PM
Restricted Application added projects: Frameworks, Baloo. · View Herald TranscriptFeb 12 2019, 9:03 PM
Restricted Application added subscribers: Baloo, kde-frameworks-devel. · View Herald Transcript
astippich requested review of this revision.Feb 12 2019, 9:03 PM

The data is taken from exiv2 library:
https://github.com/Exiv2/exiv2/blob/master/src/tags_int.cpp#L348
Unfortunately, reusing that data would introduce a lot of #ifdefs in the code, hence I added it to KFileMetaData.
This is the only property remaining that needs translation this way which KFileMetaData queries.

ngraham added inline comments.Feb 12 2019, 9:09 PM
src/formatstrings.cpp
103

Does this one mean "present but did not fire" or "there is no flash with this hardware"? If the latter, I might suggest instead "None". Otherwise this is fine the way it is.

astippich added inline comments.Feb 12 2019, 9:22 PM
src/formatstrings.cpp
103

Strictly this means that flash was disabled, not fired and that there is no hardware.
These are the strings GwenView and digiKam are using through libexiv2, and I think it makes sense not to deviate from this.

ngraham accepted this revision.Feb 12 2019, 9:27 PM

OK, looks good then!

This revision is now accepted and ready to land.Feb 12 2019, 9:27 PM
This revision was automatically updated to reflect the committed changes.