Differential D1896

Expose separate-launchers toggle in config.
ClosedPublic
Actions

Authored by hein on Jun 15 2016, 4:27 PM.

Details

Reviewers
davidedmundson
mart
Commits
R119:4fe4acfd8c88: Expose separate-launchers toggle in config.
Summary

This changes some of the assumptions of when a re-layout is needed.

Depends on D1895.

Diff Detail

Repository
R119 Plasma Desktop
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
hein updated this revision to Diff 4515.Jun 15 2016, 4:27 PM
hein retitled this revision from to Expose separate-launchers toggle in config..
hein updated this object.
hein edited the test plan for this revision. (Show Details)
hein added a reviewer: davidedmundson.
hein added a dependency: D1895: Finish implementation of mode in which launchers are not kept separate..
hein added a subscriber: plasma-devel.
Restricted Application added a project: Plasma. · View Herald TranscriptJun 15 2016, 4:27 PM
mart accepted this revision.Jun 15 2016, 4:36 PM
mart added a reviewer: mart.
This revision is now accepted and ready to land.Jun 15 2016, 4:36 PM
hein updated this revision to Diff 4516.Jun 15 2016, 4:38 PM
hein edited edge metadata.

In multi-stripe layouts don't get cute with launcher widths when
separate launchers are off.

hein updated this revision to Diff 4520.Jun 15 2016, 6:05 PM

Now that the backend no longer enforces is, follow the UI design and
only turn separate launchers on when the sort mode is manual.

hein updated this revision to Diff 4521.Jun 15 2016, 6:10 PM

Fix reference error.

hein updated this revision to Diff 4522.Jun 15 2016, 6:12 PM

Fix inverted logic.

Argh, after all this I can't get one bool right the first try :-)

davidedmundson accepted this revision.Jun 15 2016, 6:30 PM
davidedmundson edited edge metadata.
davidedmundson added inline comments.
applets/taskmanager/package/contents/config/main.xml
63 ↗(On Diff #4522)

why?

hein marked an inline comment as done.Jun 15 2016, 7:23 PM
hein added inline comments.
applets/taskmanager/package/contents/config/main.xml
63 ↗(On Diff #4522)

Merge conflict with Kai's patch, fixing.

hein updated this revision to Diff 4527.Jun 15 2016, 7:23 PM
hein marked an inline comment as done.
hein edited edge metadata.

Fix merge conflict with Kai's patch.

Closed by commit R119:4fe4acfd8c88: Expose separate-launchers toggle in config. (authored by hein). · Explain WhyJun 15 2016, 8:23 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 4522

View Options

applets/taskmanager/package/contents/code/layout.js

Loading...
View Options

applets/taskmanager/package/contents/config/main.xml

Loading...
View Options

applets/taskmanager/package/contents/ui/ConfigGeneral.qml

Loading...
View Options

applets/taskmanager/package/contents/ui/MouseHandler.qml

Loading...
View Options

applets/taskmanager/package/contents/ui/Task.qml

Loading...
View Options

applets/taskmanager/package/contents/ui/main.qml

Loading...