Differential D1895

Finish implementation of mode in which launchers are not kept separate.
ClosedPublic
Actions

Authored by hein on Jun 15 2016, 4:26 PM.

Details

Reviewers
davidedmundson
mart
Commits
R871:d50f9508b781: Finish implementation of mode in which launchers are not kept separate.
R120:d50f9508b781: Finish implementation of mode in which launchers are not kept separate.
Summary

Second half of the merge of the functionality found in Netrunner's EITM fork.

Diff Detail

Repository
R120 Plasma Workspace
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
hein updated this revision to Diff 4514.Jun 15 2016, 4:26 PM
hein retitled this revision from to Finish implementation of mode in which launchers are not kept separate..
hein updated this object.
hein edited the test plan for this revision. (Show Details)
hein added a reviewer: davidedmundson.
hein added a subscriber: plasma-devel.
Restricted Application added a project: Plasma. · View Herald TranscriptJun 15 2016, 4:26 PM
mart accepted this revision.Jun 15 2016, 4:36 PM
mart added a reviewer: mart.
This revision is now accepted and ready to land.Jun 15 2016, 4:36 PM
hein updated this revision to Diff 4518.Jun 15 2016, 6:00 PM
hein edited edge metadata.

Conceptually allow turning off launcher separation also in non-manual sort modes.

davidedmundson added inline comments.Jun 15 2016, 7:24 PM
libtaskmanager/tasksmodel.cpp
544

Sure this logic is the right way round?

(I'm not convinced it's wrong either, I'm just confused)

at the start of the function:

insertPos is the right most launcher
we iterate i from 0 to size getting from concatProxy
if we find a window we move it to be next to the launcher, potentially

  1. Should that not be if (i > insertPos) ++insertPos
  2. we don't want to increment i if we've moved something to be below i, as we'd miss an item.

Might be better to iterate i backwards like hte other loop.

hein updated this revision to Diff 4530.Jun 15 2016, 8:08 PM

Fix logic bug found by David (mad props).

hein marked an inline comment as done.Jun 15 2016, 8:08 PM
hein added inline comments.
libtaskmanager/tasksmodel.cpp
544

Was broken, should be good now!

davidedmundson accepted this revision.Jun 15 2016, 8:18 PM
davidedmundson edited edge metadata.
Closed by commit R120:d50f9508b781: Finish implementation of mode in which launchers are not kept separate. (authored by hein). · Explain WhyJun 15 2016, 8:22 PM
This revision was automatically updated to reflect the committed changes.
hein marked an inline comment as done.

Revision Contents
Changeset List

PathPackages
Mlibtaskmanager/tasksmodel.cpp (214 lines)

Diff 4518

View Options

libtaskmanager/tasksmodel.cpp

Loading...