Simplify Temperature Object
ClosedPublic

Authored by rizzitello on Sat, Feb 9, 1:51 PM.

Details

Summary

Remove public methods that clients should not use
Create a protected resetData method for unittests

Diff Detail

Repository
R232 AtCore
Branch
morePrivateTemperature
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 8136
Build 8154: arc lint + arc unit
rizzitello requested review of this revision.Sat, Feb 9, 1:51 PM
rizzitello created this revision.
patrickelectric added inline comments.Sat, Feb 9, 2:26 PM
src/core/temperature.cpp
124

Since this will be used only in QML, I believe that we can remove the argument of this slot.

rizzitello updated this revision to Diff 51263.Sat, Feb 9, 3:45 PM
  • Patricks Suggestion
rizzitello updated this revision to Diff 51264.Sat, Feb 9, 3:50 PM
  • fix wrong emit
patrickelectric accepted this revision.Sat, Feb 9, 11:34 PM
This revision is now accepted and ready to land.Sat, Feb 9, 11:34 PM
laysrodrigues accepted this revision.Mon, Feb 11, 5:12 PM
rizzitello closed this revision.Mon, Feb 11, 5:31 PM