Differential D18825

Replace recursive isDirHidden with iterative one, allow const argument
ClosedPublic
Actions

Authored by bruns on Feb 7 2019, 7:17 PM.

Details

Reviewers
poboiko
ngraham
Group Reviewers
Baloo
Frameworks
Commits
R293:38698b1a4c9e: Replace recursive isDirHidden with iterative one, allow const argument
Summary

The non-unix implementation modifies its QDir argument to walk up the
tree. Create a copy instead.
The copy cost is amortized by no longer having to reset the dir in the
calling code, for the unix-code it is a net win.

Diff Detail

Repository
R293 Baloo
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
bruns created this revision.Feb 7 2019, 7:17 PM
Restricted Application added projects: Frameworks, Baloo. · View Herald TranscriptFeb 7 2019, 7:17 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
bruns requested review of this revision.Feb 7 2019, 7:17 PM
ngraham accepted this revision.Feb 7 2019, 7:29 PM
This revision is now accepted and ready to land.Feb 7 2019, 7:29 PM
Closed by commit R293:38698b1a4c9e: Replace recursive isDirHidden with iterative one, allow const argument (authored by bruns). · Explain WhyFeb 7 2019, 11:02 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/file/fileindexerconfig.cpp (18 lines)

Diff 51138

View Options

src/file/fileindexerconfig.cpp

Loading...