Use KTextEditor::Document::wordAt() instead of custom implementation
AbandonedPublic
Actions

Authored by dhaumann on Jun 14 2016, 8:46 PM.

Details

Reviewers

kfunk

Summary

The code is mostly unused as far as I can see...

Repository

R33 KDevPlatform

Branch

5.0

Lint

No Linters Available

Unit

No Unit Test Coverage

dhaumann retitled this revision from to Use KTextEditor::Document::wordAt() instead of custom implementation.

dhaumann updated this object.

dhaumann edited the test plan for this revision. (Show Details)

dhaumann added a reviewer: kfunk.

looks good to me ;)

shell/textdocument.cpp
517	Hmm, the tilde will not be covered by wordAt, will it? This should probably be fixed in the C++ highlighter though, it's wrong here anyways.

shell/textdocument.cpp
517	Yes, you are correct. But then, why was the '~' in there in the first place? Can anyone tell? And there is another difference below: for empty strings, PartDocument::textWord() was returned. I cannot tell whether this change in behavior will do any bad, since my knowledge of KDevelop mainly lies in KTextEditor :^)

I think for C++ destructors.

The function is only called in a few fairly uncritical places, I think chances of breakage are low ...

See Sven's comments

This revision now requires changes to proceed.Jun 15 2016, 9:48 AM

Probably not worth the effort, and the side-effects are unclear.

			Path	Packages
M			language/interfaces/editorcontext.cpp (7 lines)
M			shell/textdocument.cpp (21 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	4477	ccb7e73		Jun 14 2016, 8:46 PM	★	★