Differential D18755

Read IKWS search provider icon from desktop file
ClosedPublic
Actions

Authored by broulik on Feb 5 2019, 11:37 AM.

Details

Reviewers
shubham
Group Reviewers
Frameworks
Commits
R241:e1c386f04303: Read IKWS search provider icon from desktop file
Summary

Allows to give them more meaningful icons rather than the one derived from URL (usually generic web icon).
This is probably from when Konqueror was still widely used and a favicon was likely present.

Diff Detail

Repository
R241 KIO
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Feb 5 2019, 11:37 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptFeb 5 2019, 11:37 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
broulik requested review of this revision.Feb 5 2019, 11:37 AM
broulik mentioned this in D18730: Use breeze icons for search providers.
shubham accepted this revision.Feb 5 2019, 11:50 AM
This revision is now accepted and ready to land.Feb 5 2019, 11:50 AM
Closed by commit R241:e1c386f04303: Read IKWS search provider icon from desktop file (authored by broulik). · Explain WhyFeb 5 2019, 12:01 PM
This revision was automatically updated to reflect the committed changes.

Showing Only Differences

This revision modifies 2 more files that are hidden because they were not modified between selected diffs and they have no inline comments.

Revision Contents
Changeset List

Path
No data available.

Diff 50938