Differential D18750

Bail out if stream is negative
ClosedPublic
Actions

Authored by broulik on Feb 5 2019, 10:29 AM.

Details

Reviewers
fvogt
yurchor
Commits
R343:caf68da41865: Bail out if stream is negative
Summary

Documentation says it returns "the non-negative stream number in case of success".

It can also return AVERROR_DECODER_NOT_FOUND which is -1381258232 and not -1, leading to crashes when trying to preview video files without video streams.

Test Plan

Whatever stable branch

Diff Detail

Repository
R343 FFmpeg Thumbnailers
Lint
Lint Skipped
Unit
Unit Tests Skipped
broulik requested review of this revision.Feb 5 2019, 10:29 AM
broulik created this revision.
broulik edited the summary of this revision. (Show Details)
broulik edited the summary of this revision. (Show Details)
fvogt accepted this revision.Feb 5 2019, 10:37 AM
This revision is now accepted and ready to land.Feb 5 2019, 10:37 AM
yurchor accepted this revision.Feb 5 2019, 10:49 AM

Thanks.

Closed by commit R343:caf68da41865: Bail out if stream is negative (authored by broulik). · Explain WhyFeb 5 2019, 11:20 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mffmpegthumbnailer/moviedecoder.cpp (2 lines)

Diff 50921

View Options

ffmpegthumbnailer/moviedecoder.cpp

Loading...