Differential D18695

AggregatedFetchScope: fix fetchAllAttributes for tags.
ClosedPublic
Actions

Authored by dfaure on Feb 3 2019, 2:22 PM.

Details

Reviewers
dvratil
Commits
R165:ccea01c5cd15: AggregatedFetchScope: fix fetchAllAttributes for tags.
Summary

This is a third case for aggregation: the default is *true*,
so any subscriber with default settings was NOT calling
AggregatedTagFetchScope::setFetchAllAttributes, so
d->fetchAllAttributes > 0 was false, unexpectedly.

Count the number of subscribers who call with false, and return
false only if all of them agree with that.

Test Plan

tagtest

Diff Detail

Branch
2019_01_aggregatedfetchscope_test
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 7826
Build 7844: arc lint + arc unit
dfaure requested review of this revision.Feb 3 2019, 2:22 PM
dfaure created this revision.
dfaure updated this revision to Diff 50792.Feb 3 2019, 5:43 PM

also add lower-level unittest

dfaure added a subscriber: ervin.Feb 3 2019, 6:56 PM
dvratil accepted this revision.Feb 5 2019, 12:02 PM

Thanks!

This revision is now accepted and ready to land.Feb 5 2019, 12:02 PM
Closed by commit R165:ccea01c5cd15: AggregatedFetchScope: fix fetchAllAttributes for tags. (authored by dfaure). · Explain WhyFeb 5 2019, 8:26 PM
This revision was automatically updated to reflect the committed changes.
Restricted Application added a project: KDE PIM. · View Herald TranscriptFeb 5 2019, 8:26 PM

Showing Only Differences

This revision modifies 2 more files that are hidden because they were not modified between selected diffs and they have no inline comments.

Revision Contents
Changeset List

Diff 50792

View Options

autotests/server/aggregatedfetchscopetest.cpp

Loading...