Remove monochrome preferences-system symlinks
AbandonedPublic

Authored by ndavis on Jan 30 2019, 6:11 PM.

Details

Reviewers
ngraham
Group Reviewers
VDG
Summary

Remove some monochrome preferences-system symlinks that were added for compatibility with 3rd party applications. For some reason, preferences-system was only showing up as a monochrome icon with the Breeze icon theme (light version, not Breeze Dark). While I don't think the source of the problem was these symlinks, removing them does fix the issue. I am removing them to prevent the problem from affecting users in KF5.55.

Diff Detail

Repository
R266 Breeze Icons
Branch
remove-monochrome-preferences-system (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 7707
Build 7725: arc lint + arc unit
ndavis created this revision.Jan 30 2019, 6:11 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptJan 30 2019, 6:11 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
ndavis requested review of this revision.Jan 30 2019, 6:11 PM
ndavis edited the summary of this revision. (Show Details)Jan 30 2019, 6:12 PM
ngraham accepted this revision.Jan 30 2019, 6:15 PM
ngraham added a subscriber: ngraham.

Instead of landing this patch, please revert the offending commit itself using git revert 14bbb8f64ba2d4aa29b3a3b3b186fca36979fbef, add the explanation message from here into the commit message for the reversion commit, and push directly. Then you can abandon this revision.

That will make the git history of this issue more obvious for the future.

This revision is now accepted and ready to land.Jan 30 2019, 6:15 PM
ndavis abandoned this revision.Jan 30 2019, 6:33 PM