Use KModifierKeyInfo to display shortcut badges while holding Super
BUG: 401768
Details
Details
- Reviewers
mvourlakos - Group Reviewers
Latte Dock - Commits
- R878:6f1c66f7d202: Display shortcut badges while holding Super
Just playing with it.
I still don't understand the GlobalShortcut class very well, correct me if I make any mistake.
Diff Detail
Diff Detail
- Repository
- R878 Latte Dock
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
| app/CMakeLists.txt | ||
|---|---|---|
| 57 | please add the new framework to README file also | |
Comment Actions
- It works without any issue with my use case. Not sure other cases. Can you test it ?
- No, because KModifierKeyInfo does not work under wayland: https://bugs.kde.org/show_bug.cgi?id=370454
But I guess when it supports wayland, Latte will do too.
| app/globalshortcuts.cpp | ||
|---|---|---|
| 283 | shouldnt this be valid for Key_Super_R also? | |
| app/globalshortcuts.cpp | ||
|---|---|---|
| 278 | I think a lower interval may be better e.g. 500ms | |
Comment Actions
@trmdi this is ok, you can merge it and afterwards we can discuss how the Meta behavior should be enabled/disabled/adjusted...
Meta is also used for showing Application Launcher so the two functionalities could be messed up together.
any ideas?
Take note that with latest commits in Latte git version, now Latte shows also the ShortcutBadges from plasma shortcuts for applets
that would probably mean that more Latte Views should be shown if their applets have plasma shortcuts assigned
Comment Actions
I've been thinking about the Meta behavior. Some ideas:
- When the holding action is detected: just show Latte views with badges and do not activate the App Launcher if users release the Meta key. App Launcher can be activated ONLY IF the holding action is not detected
- Only show Latte views with badges if: press "Meta+`" (for the wayland case, or users don't want to wait to see the badges) or holding Meta is detected.
(Currently, if I press a shortcut to activate an item, it will show the badges -> not needed)
- Timeout for determining it's a holding action or not should be 1-2s
This patch is just a draft, so you should improve it before merging by yourself.
Comment Actions
sounds ok
(Currently, if I press a shortcut to activate an item, it will show the badges -> not needed)
- Timeout for determining it's a holding action or not should be 1-2s
it is too low I will play with it
This patch is just a draft, so you should improve it before merging by yourself.
- I will probably merge it and afterwards I will fix the issues e.g. if any other modifier is pressed when the Meta timer ends then the ShowDocks action shouldnt be trigerred but the timer should be restarted.
- That means that the globalshortcuts class will be adjusted in order to track the modifiers that are pressed, Super, Shift, Ctrl and Alt, I dont know if there are any more...
- Afterwards the hack that is relevant to X11 and was copy pasted from Plasma Activites Explorer in order to track when Meta is released is not needed any more and the new infrastructure will be used.
We will play with this with iterations and through kde bugs tracker in order to fix any issues
There is also a chance that the user will be able to enable/disable that behavior from Latte Preferences in case some users hit corner cases that break their workflows.
Comment Actions
@trmdi can you please test latest master for global shortcuts?
features supported are the following:
- the Meta pressed case
- applets can show their Plasma shortcuts at their Shortcut Badges
- When showViews is trigerred only latte views that have shortcuts are shown if they are hidden and for all of them independent of their number, all badges are shown at all views (previously only shortcut badges for maximum two views could be shown)