Prepare KSplash for KDED dropping KSplash support
ClosedPublic
Actions

Authored by davidedmundson on Jun 14 2016, 9:13 AM.

Details

Reviewers

Group Reviewers

Commits

Summary

We want to drop workspace code from KDED as it doesn't make much sense
semantically.

This patch ignores the messages from kded, so that they can be dropped
in a future frameworks release and introduces a new signal sent from
startkde.

This puts all workspace related code in workspace.

Repository

R120 Plasma Workspace

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

davidedmundson retitled this revision from to Prepare KSplash for KDED dropping KSplash support.

davidedmundson updated this object.

davidedmundson edited the test plan for this revision. (Show Details)

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

Thanks!

ksplash/ksplashqml/splashapp.cpp
106	At some point this comment will be outdated ;-)

This revision is now accepted and ready to land.Jun 14 2016, 9:19 AM

This revision was automatically updated to reflect the committed changes.

graesslin added a subscriber: graesslin.

graesslin added inline comments.

startkde/startkde.cmake
354	don't forget to do the same in startplasmacompositor

This revision is now accepted and ready to land.Jun 14 2016, 9:33 AM

			Path	Packages
M			ksplash/ksplashqml/splashapp.cpp (12 lines)
M			startkde/startkde.cmake (1 line)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	4438	a38fd34		Jun 14 2016, 9:13 AM	★	★
Diff 2	4440	91f80fb	rPLASMAWORKSPACEb6058a09aed209f752f96159283da0c8259a971f	Jun 14 2016, 9:22 AM	★	★