Calling readAll() after close() is just nonsense, QIODevice checks
the open status before reading, and warns (and returns -1) if closed.
False warnings make people start thinking in the wrong direction when
debugging an actual issue.
dvratil | |
sengels |
Calling readAll() after close() is just nonsense, QIODevice checks
the open status before reading, and warns (and returns -1) if closed.
False warnings make people start thinking in the wrong direction when
debugging an actual issue.
ctest --verbose -R sqlite-tagtest no longer has all these warnings.
Automatic diff as part of commit; lint not applicable. |
Automatic diff as part of commit; unit tests not applicable. |
The readAll()s after close() were needed IIRC, because reopening the socket and reading from it caused junk to be read from the buffer after reopening. This may have been caused by me doing something wrong. However, to make sure this does not keep happening, I'd suggest to always recreate the socket in doReconnect() instead of just reconnecting if it already exists.