Differential D18513

[wayland] Send VirtualDesktop::done after editing a property
ClosedPublic
Actions

Authored by davidedmundson on Jan 25 2019, 9:43 AM.

Details

Reviewers
zzag
Group Reviewers
KWin
Commits
R108:f3c1786a8974: [wayland] Send VirtualDesktop::done after editing a property
Summary

The protocol is double buffered, after changing the name done should be
sent so that clients update.

Test Plan

Changed a VD name on wayland
Pager tooltip updated

Diff Detail

Repository
R108 KWin
Branch
master
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 7494
Build 7512: arc lint + arc unit
davidedmundson created this revision.Jan 25 2019, 9:43 AM
Restricted Application added a project: KWin. · View Herald TranscriptJan 25 2019, 9:43 AM
Restricted Application added a subscriber: kwin. · View Herald Transcript
davidedmundson requested review of this revision.Jan 25 2019, 9:43 AM
zzag added a subscriber: zzag.Jan 25 2019, 9:51 AM

... and after any other property changes done after that.

Seems sensible.

virtualdesktops.cpp
114–120

Do we have to send the done event here as well?

davidedmundson added inline comments.Jan 25 2019, 10:01 AM
virtualdesktops.cpp
114–120

Depends on whether you consider "activated" to be a property, which is quite a loosely defined concept. You could argue a case for either.

zzag accepted this revision.Jan 25 2019, 10:03 AM
This revision is now accepted and ready to land.Jan 25 2019, 10:03 AM
Closed by commit R108:f3c1786a8974: [wayland] Send VirtualDesktop::done after editing a property (authored by davidedmundson). · Explain WhyJan 25 2019, 10:34 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mvirtualdesktops.cpp (1 line)

Diff 50220

View Options

virtualdesktops.cpp

Loading...