Fix missing parentheses around macro
ClosedPublic

Authored by jpalecek on Jan 22 2019, 2:37 AM.

Details

Summary

Defining macro isRunning by

#define isRunning() something == something_else

has its problems. Elsewhere in the code, there is

if(!isRunning())

which expands to !something == something_else, not what you would probably mean. I have found this due to a gcc warning.

Diff Detail

Repository
R434 Kopete
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 7397
Build 7415: arc lint + arc unit
jpalecek created this revision.Jan 22 2019, 2:37 AM
Restricted Application added a project: Kopete. · View Herald TranscriptJan 22 2019, 2:37 AM
Restricted Application added a subscriber: kopete-devel. · View Herald Transcript
jpalecek requested review of this revision.Jan 22 2019, 2:37 AM
jpalecek edited the summary of this revision. (Show Details)
rakuco accepted this revision.Oct 13 2019, 1:16 PM
rakuco added a subscriber: rakuco.

Looks fine to me, thanks for the patch.

This revision is now accepted and ready to land.Oct 13 2019, 1:16 PM
This revision was automatically updated to reflect the committed changes.