Add placeholders for the search lines
ClosedPublic

Authored by yurchor on Jan 21 2019, 2:28 PM.

Details

Summary

Some people need them

BUG: 403445

Test Plan

Can be compiled, installed, can be spotted in the GUI.

Diff Detail

Repository
R223 Okular
Branch
placeholders (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 7374
Build 7392: arc lint + arc unit
yurchor created this revision.Jan 21 2019, 2:28 PM
Restricted Application added a project: Okular. · View Herald TranscriptJan 21 2019, 2:28 PM
Restricted Application added a subscriber: okular-devel. · View Herald Transcript
yurchor requested review of this revision.Jan 21 2019, 2:28 PM

These strings are all probably too long given the very limited horizontal space available by default. I bet it would be even worse in wordy languages like German and Brazilian Portuguese! Also I'm not sure including the thing that's being filtered is necessary given that there's a header right above these text fields. Finally, we're trying to encourage the use of the word "Search" instead of "Filter" for search fields.

So basically all of these should just say, "Search..."

yurchor updated this revision to Diff 49993.Jan 21 2019, 3:01 PM

Use "Search..." for all placeholders

ngraham accepted this revision.Jan 21 2019, 4:36 PM

Thanks!

This revision is now accepted and ready to land.Jan 21 2019, 4:36 PM
This revision was automatically updated to reflect the committed changes.