Details
- Reviewers
apol - Commits
- R256:f44d8e21dad7: Update KEXI master to 3.3
Diff Detail
- Repository
- R256 Flatpak packaging for KDE Applications
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
This looks fine to me, but as the original author Aleix should confirm this is correct.
Landed, now how to rebuild it? Can I get rights to click Rebuild?
I may want this in other cases, e.g. when kexi.git is unchanges but when dependencies changed and we want to test things while testers are waiting for binaries. For nightly builds it means one test per 24h I'd assume?
Our Flatpak builds monitor the source repository (in this case the Kexi repository) for changes, so once there has been a change there the build should trigger automatically sometime in the next 24 hours.
Thanks Ben, it's hard to argue with this standard behavior. I am wondering though how to trigger the build in projects like KEXI - there can be weeks of development when changes are in kdb.git only and not in kexi.git. More precisely, how to deal with that without adding artificial commits to kexi.git.
At this time your only way will be to ask in #kde-sysadmin for someone to trigger the build for you manually.
Thanks a lot @apol, it looks promising and clean. I have questions based on my limited knowledge of these json files:
- kreport, kproperty, kdb modules - can their branch be 3.2 too? They're BC but still using stable dependencies for stable builds would be better
- the top level "branch" attribute is master, not sure what it means
- what would be the URL at https://binary-factory.kde.org/ for the stable?
PS I am on vacation this week so may respond with delays :)
done
- the top level "branch" attribute is master, not sure what it means
changed
- what would be the URL at https://binary-factory.kde.org/ for the stable?
https://binary-factory.kde.org/view/Flatpak/job/Kexi_stable_flatpak/
The Flatpak repository can be found at http://distribute.kde.org/flatpak-apps-testing/
Thanks @bcooksley and @apol
I've reported icons issue https://bugs.kde.org/show_bug.cgi?id=404579 (breeze is the only theme having all icons supported for now but it does not work in flatpak case probably because kexi searches them wrong way)