Differential D18378

Fix bug 402077 for 5.14.x
Needs ReviewPublic
Actions

Authored by bero on Jan 19 2019, 3:13 AM.

Details

Reviewers
jgrulich
Summary

This fixes preselecting a filename and directory in xdg-desktop-portal-kde on the 5.14.x branch. This bug is already fixed on master by the move to KFileWidget instead of QFileDialog -- this fix is less intrusive and probably more suitable for another 5.14.x release.

BUG: 402077

Test Plan

Add patch, kill xdg-desktop-portal-kde, go to a website with firefox, select "Save Page As", make sure the filename and save directory are correct.

Diff Detail

Repository
R838 Flatpak Support: KDE Portal for XDG Desktop
Lint
Lint Skipped
Unit
Unit Tests Skipped
bero created this revision.Jan 19 2019, 3:13 AM
Restricted Application added a project: Plasma. · View Herald TranscriptJan 19 2019, 3:13 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
bero requested review of this revision.Jan 19 2019, 3:13 AM
ngraham added a subscriber: ngraham.EditedJan 19 2019, 3:16 AM

Unfortunately there aren't any more 5.14.x released schedules. But you could target this for the 5.12 LTS branch maybe?

ngraham added inline comments.Jan 19 2019, 3:22 AM
src/filechooser.cpp
298

KDE coding style:

if (thing) {
    do stuff;
}

Spaces around the equals sign please

Revision Contents
Changeset List

PathPackages
Msrc/filechooser.cpp (5 lines)

Diff 49858

View Options

src/filechooser.cpp

Loading...