bero (Bernhard Rosenkraenzer)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Dec 19 2017, 10:55 PM (144 w, 1 d)
Availability
Available

Recent Activity

Feb 20 2020

bero added a comment to D27514: Fix incorrect use of case statements in accountmodel.cpp.

Another option would be switching the code to use if instead of switch/case so the || operator would actually do what the code expected (and x || x, unlike duplicate case values, isn't an error)

Feb 20 2020, 12:21 AM · Plasma
bero updated the diff for D27514: Fix incorrect use of case statements in accountmodel.cpp.

Probably best to just add a comment explaining what needs to be done if AccountModel::* roles ever diverge from DisplayRole/DecorationRole...

Feb 20 2020, 12:19 AM · Plasma
bero added a comment to D27514: Fix incorrect use of case statements in accountmodel.cpp.

Actually the obvious fix doesn't work (thought it was so obvious that I submitted it before testing, sorry) because Qt::DisplayRole and AccountModel::FriendlyName are both 0 (-> duplicate case value) and Qt::DecorationRole and AccountModel::Face are both 1 (-> duplicate case value). Also explains why the bogus variant before "worked" - (Qt::DisplayRole || AccountModel::FriendlyName) = 0 || 0 = 0 = Qt::DisplayRole = AccountModel::FriendlyName and (Qt::DecorationRole || AccountModel::Face) = 1 || 1 = 1 = Qt::DecorationRole = AccountModel::Face

Feb 20 2020, 12:11 AM · Plasma
bero edited reviewers for D27514: Fix incorrect use of case statements in accountmodel.cpp, added: Plasma; removed: Frameworks.
Feb 20 2020, 12:02 AM · Plasma
bero requested review of D27514: Fix incorrect use of case statements in accountmodel.cpp.
Feb 20 2020, 12:01 AM · Plasma

Nov 6 2019

bero requested review of D25162: Fix build with Qt 5.14+.
Nov 6 2019, 12:04 AM

Sep 23 2019

bero added a comment to D21145: Make KTorrent work with current GeoIP files.

Yes, currently busy with something totally different, but that should be finished tomorrow.

Sep 23 2019, 10:39 AM

Aug 3 2019

bero updated the summary of D22912: Fix build with clang 9.0.
Aug 3 2019, 9:02 PM · Latte Dock, Plasma
bero requested review of D22912: Fix build with clang 9.0.
Aug 3 2019, 8:51 PM · Latte Dock, Plasma

May 11 2019

bero requested review of D21145: Make KTorrent work with current GeoIP files.
May 11 2019, 8:55 PM

Jan 19 2019

bero requested review of D18378: Fix bug 402077 for 5.14.x.
Jan 19 2019, 3:13 AM · Plasma