Differential D18304

Use the default RGB Colors for the XYZ Axis
ClosedPublic
Actions

Authored by karinapassos on Jan 16 2019, 8:57 PM.

Details

Reviewers
apol
tcanabrava
Group Reviewers
KDE Edu
Commits
R323:c2c1d883a5f9: Use the default RGB Colors for the XYZ Axis
Summary

Only using red to plot the axis is misleading as one cannot easily identify which axis is pointing to where. Using the default standard to use RGB helps on that. If the plotted values are colorized in a rainbow fashion this change will probably have a worse view, in that case I believe a string representation of the axis will be needed, but that's for another patch.

Diff Detail

Repository
R323 Analitza
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
karinapassos created this revision.Jan 16 2019, 8:57 PM
Restricted Application added a project: KDE Edu. · View Herald TranscriptJan 16 2019, 8:57 PM
Restricted Application added a subscriber: kde-edu. · View Herald Transcript
karinapassos requested review of this revision.Jan 16 2019, 8:57 PM
karinapassos retitled this revision from changes in the axes colors to changes on the axes colors.Jan 16 2019, 11:07 PM
karinapassos edited the summary of this revision. (Show Details)
karinapassos added reviewers: KDE Edu, apol, tcanabrava.
tcanabrava retitled this revision from changes on the axes colors to Use the default RGB Colors for the XYZ Axis.Jan 17 2019, 8:25 AM
tcanabrava edited the summary of this revision. (Show Details)
tcanabrava added a comment.Jan 17 2019, 8:29 AM

karina, I belive the patch is good, I'll just wait for Aleix Pol answer, The two nitpicks that I posted are quite minor so I'll not block the review for those. we can fix those later.

analitzaplot/plotitem.cpp
2

stray empty line.

analitzaplot/plotter3d_es.cpp
47

stray empty space

karinapassos edited the summary of this revision. (Show Details)Jan 17 2019, 1:36 PM
apol added a comment.Jan 19 2019, 5:58 AM

Looks good to me, please fix the issues pointed out by Tomaz so we can land the patch.

tcanabrava accepted this revision.Jan 29 2019, 9:52 AM
This revision is now accepted and ready to land.Jan 29 2019, 9:52 AM
Closed by commit R323:c2c1d883a5f9: Use the default RGB Colors for the XYZ Axis (authored by karinapassos, committed by tcanabrava). · Explain WhyJan 29 2019, 9:55 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 50465

View Options

analitzaplot/plotitem.cpp

Loading...
View Options

analitzaplot/plotter3d_es.cpp

Loading...